Skip to content

Reconcile payment status on Adyen webhook + accept externally tokenised cards - #147

Open
KBbitsP wants to merge 4 commits into
maint-for-0-24-xfrom
adyen-reconcile-external-token-0-24-x
Open

KBbitsP wants to merge 4 commits into
maint-for-0-24-xfrom
adyen-reconcile-external-token-0-24-x

Conversation

@KBbitsP

@KBbitsP KBbitsP commented Sep 25, 2026

Copy link
Copy Markdown
  1. Webhook reconciliation (fix done by Max)

    • Notification now updates the plugin response row by kb_payment_transaction_id (not kb_payment_id), so earlier transactions of the same payment are not overwritten.
    • On a successful notification the plugin asks Kill Bill core to refresh the payment, so the payment moves from PENDING to SUCCESS immediately instead of waiting for the Janitor.
  2. Externally tokenised cards (feature)

    • addPaymentMethod accepts two plugin properties:
      • recurringDetailReference: an Adyen token created outside the plugin
      • shopperReference: the Adyen shopperReference that token was stored under
    • purchasePayment sends the stored shopperReference with the token; if the token was later
      replaced by a /checkout webhook, it falls back to the Kill Bill account id (existing behaviour).
    • Needed when the card is tokenised before the Kill Bill account exists.
  3. Build / docs

    • Lombok 1.18.22 -> 1.18.34 (compiles on JDK 11 and 21).
    • README: DDL requirement, payment status after a notification, new properties.

@sbrossie sbrossie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am slightly confused about this PR: Tt looks like it includes similar things from #141 but also additional things.

Given master is now against 0.25, it makes sense to have a separate PR against maint-for-0-24, but why are PRs different - don't we need everything in master (0.25)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants