Changed last_modified calculation to be a bit more specific#22
Open
edelabar wants to merge 4 commits intokinnetica:masterfrom
Open
Changed last_modified calculation to be a bit more specific#22edelabar wants to merge 4 commits intokinnetica:masterfrom
edelabar wants to merge 4 commits intokinnetica:masterfrom
Conversation
added 4 commits
September 3, 2014 11:20
…be set by URL pattern
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the README with details and provided examples.
Basically this refactor moves the calculation of last_modified to the Page/Post level, which allows for other Generator's Page/Post subclasses to provide a more accurate value. It's a bit convoluted when it comes to integrating with other coupling to other Generators so I'll understand if you choose to ignore this, but I thought it was useful so here it is.