Follow upon cloudwatch formatters - #138
Conversation
…le the formatting of the record message to CloudWatch which also make it possible to extent the formatting logic
| self.sequence_tokens[stream_name] = None | ||
|
|
||
| if isinstance(message.msg, Mapping): | ||
| if self.json_serialize_default and isinstance(message.msg, Mapping): |
There was a problem hiding this comment.
Dumping JSON will only happen once so it is fine to leave this here instead of removing it.
kislyuk
left a comment
kislyuk
left a comment
There was a problem hiding this comment.
This looks good overall, but it needs tests for CloudWatchJSONFormatter. Also, please replace all occurrences of "CloudWatch" with "CloudWatchLog". The former is a different AWS product that is only vaguely related to CWL, so we want to avoid confusion there.
| self.fields = fields | ||
|
|
||
| def format(self, message): | ||
| if self.fields == '__all__': |
There was a problem hiding this comment.
Please remove the magic value "all" and use None as the placeholder for keeping all field values instead.
|
@terencehonles I can add you as a collaborator in this repo if you want CI tests to run correctly (secrets can't be provided to forks). Do you want me to do that? |
Sure that's fine. |
|
Actually that might require me to create a new PR since I think that would require this PR come from a branch in this repo. I'm not in a rush for these changes and not sure if it might make sense to check how the credentials are locked down. Not sure if you plan on changing the settings to allow forks once you've done that. If you're not comfortable with that we should probably change the tests to use mocks. |
|
@terencehonles are you planning to update this PR for the feedback above? Your changes look good overall, the PR just needs those minor improvements to be merged. |
|
I'll try to tend to this when I can. I bumped #144 and made it more useful by actually running mypy (instead of just using it for Sphinx docs), but I'll probably want to try to focus on #139 since I've had to remove this library in order to allow uWSGI to reload gracefully which I hadn't really noticed it wasn't doing until I increased the reload timeout and noticed it was using the full timeout much more often than I would have expected. |
3 participants
This PR brings #117 up to date and addresses the backwards incompatibility mentioned here #117 (comment)