Add School Package List in Courier Packages#129
Open
barshathakuri wants to merge 2 commits intodevelopfrom
Open
Add School Package List in Courier Packages#129barshathakuri wants to merge 2 commits intodevelopfrom
barshathakuri wants to merge 2 commits intodevelopfrom
Conversation
samshara
reviewed
May 18, 2022
app/views/Moderation/CourierPackages/Actions/SchoolPackagesModal/index.tsx
Outdated
Show resolved
Hide resolved
samshara
reviewed
May 18, 2022
| className={styles.relatedBooksModal} | ||
| backdropClassName={styles.modalBackdrop} | ||
| onCloseButtonClick={onModalClose} | ||
| heading="School Package" |
Contributor
There was a problem hiding this comment.
use the appropriate heading name.
Comment on lines
+82
to
+91
| <Button | ||
| className={styles.button} | ||
| name={undefined} | ||
| title="View school packages" | ||
| onClick={showSchoolPackagesModal} | ||
| disabled={disabled} | ||
| variant="tertiary" | ||
| > | ||
| Schools | ||
| </Button> |
Contributor
There was a problem hiding this comment.
it's better to show this button conditionally. If schoolPackages exits in given courierPackage, then show this button.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.