Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions backend/news/+updateDisabletoClickableProfileLink.bugfix
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Use "clickable_profile_link' instead of 'disable_profile_link' @Tishasoumya-02
10 changes: 5 additions & 5 deletions backend/src/kitconcept/core/controlpanel/kitconcept.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,13 @@ class IKitconceptSettings(Interface):
required=False,
)

disable_profile_links = schema.Bool(
title=_("Non-clickable Profiles"),
clickable_profile_links = schema.Bool(
title=_("Clickable profiles"),
description=_(
"Person profiles are not clickable in teasers, grids, listings, and search"
"Person profiles are clickable in teasers, grids, listings, and search"
),
required=False,
default=False,
default=True,
)


Expand Down Expand Up @@ -68,4 +68,4 @@ def __call__(self, data):
IKitconceptSettings, prefix="kitconcept.core.settings"
)
data["kitconcept.custom_css"] = settings.custom_css
data["kitconcept.disable_profile_links"] = settings.disable_profile_links
data["kitconcept.clickable_profile_links"] = settings.clickable_profile_links
2 changes: 1 addition & 1 deletion backend/src/kitconcept/core/profiles/base/metadata.xml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?xml version="1.0" encoding="utf-8"?>
<metadata>
<version>20260701001</version>
<version>20260706001</version>
</metadata>
1 change: 1 addition & 0 deletions backend/src/kitconcept/core/upgrades/configure.zcml
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,6 @@
<include package=".v20260619001" />
<include package=".v20260620001" />
<include package=".v20260701001" />
<include package=".v20260706001" />

</configure>
20 changes: 20 additions & 0 deletions backend/src/kitconcept/core/upgrades/v20260706001/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
from plone.registry.interfaces import IRegistry
from Products.GenericSetup.tool import SetupTool
from zope.component import getUtility


def rename_disable_to_clickable_profile_links(tool: SetupTool):
"""Migrate disable_profile_links to clickable_profile_links.

The old ``disable_profile_links`` flag was inverted and renamed to
``clickable_profile_links``, so carry the previous value over with the
opposite meaning and drop the stale record.
"""
old_key = "kitconcept.core.settings.disable_profile_links"
new_key = "kitconcept.core.settings.clickable_profile_links"
registry = getUtility(IRegistry)
records = registry.records
if old_key in records:
disabled = registry[old_key]
registry[new_key] = not disabled
del records[old_key]
22 changes: 22 additions & 0 deletions backend/src/kitconcept/core/upgrades/v20260706001/configure.zcml
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
<configure
xmlns="http://namespaces.zope.org/zope"
xmlns:genericsetup="http://namespaces.zope.org/genericsetup"
>

<genericsetup:upgradeSteps
profile="kitconcept.core:base"
source="20260701001"
destination="20260706001"
>
<genericsetup:upgradeDepends
title="Add clickable_profile_links to kitconcept registry"
import_profile="kitconcept.core:dependencies"
import_steps="plone.app.registry"
/>
<genericsetup:upgradeStep
title="Rename disable_profile_links to clickable_profile_links"
handler=".rename_disable_to_clickable_profile_links"
/>
</genericsetup:upgradeSteps>

</configure>
2 changes: 1 addition & 1 deletion backend/tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def current_versions() -> CurrentVersions:
from kitconcept.core import __version__

return CurrentVersions(
base="20260701001",
base="20260706001",
dependencies="1000",
package=__version__,
)
Expand Down
2 changes: 1 addition & 1 deletion docs/docs/concepts/what-is-core.md
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ After bumping the version of `kitconcept.core:base`, we need to create a new upg
handler="..utils.null_upgrade_step"
/>
<genericsetup:upgradeDepends
title="Adds disable_profile_links setting to kitconcept settings"
title="Adds clickable_profile_links setting to kitconcept settings"
import_profile="kitconcept.core:dependencies"
import_steps="plone.app.registry"
/>
Expand Down
2 changes: 1 addition & 1 deletion docs/docs/how-to-guides/upgrade-plone.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ Make a quick search for `plone_version` in the `backend/tests` folder and update
/>
<!-- Additional step updating registry settings defined in kitconcept.core:dependencies -->
<genericsetup:upgradeDepends
title="Adds disable_profile_links setting to kitconcept settings"
title="Adds clickable_profile_links setting to kitconcept settings"
import_profile="kitconcept.core:dependencies"
import_steps="plone.app.registry"
/>
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix the size of i icon in toast @Tishasoumya-02
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
.Toastify__toast.Toastify__toast--info.return-to-origin-toast
.Toastify__toast.Toastify__toast--info.return-to-origin-toast {
.toast-box-center {
padding-top: 20px;
padding-top: 20px;
}

.Toastify__toast-body svg.icon {
height: 28px !important;
}
}

.return.toast-box {
Expand Down
1 change: 1 addition & 0 deletions news/+clickableProfileLink.documentation
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Update docs for clickable profile link control panel setting @Tishasoumya-02
Loading