Local search: path-scoped suggestions, explicit path_prefix wins (#101) - #102
Closed
reekitconcept wants to merge 2 commits into
Closed
Local search: path-scoped suggestions, explicit path_prefix wins (#101)#102reekitconcept wants to merge 2 commits into
reekitconcept wants to merge 2 commits into
Conversation
Port of the local-scoping fixes from the feature-ai-rag line (#100), without the AI-search parts: - @solr-suggest accepts an optional path_prefix and filters with path_parents, so the livesearch suggestions honor a subtree scope like the search results do (integration test included; pathPrefix argument on the solrSearchSuggestions action). - searchPathPrefix(): an explicit path_prefix URL param wins over the getPathPrefix heuristic, which treats every single-segment path as a language root and silently dropped the prefix for top-level subsites and workspaces. The multilingual path handling neutralizing path_prefix on non-PAM sites (#101 item 3) remains open.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #101 (items 1 and 2). Port of the local-scoping fixes from the
feature-ai-ragline (#100), without the AI-search parts:@solr-suggestaccepts an optionalpath_prefixand filters withpath_parents, so livesearch suggestions honor a subtree scope like the search results do (integration test included;pathPrefixargument on thesolrSearchSuggestionsaction, backward compatible).searchPathPrefix(): an explicitpath_prefixURL param wins over thegetPathPrefixheuristic, which treats every single-segment path as a language root (/de,/en) and silently dropped the prefix for top-level subsites/workspaces.Item 3 of #101 (multilingual handling neutralizing
path_prefixon sites without plone.app.multilingual) remains open.Not to be merged yet — queued for the release line together with #96 and #99.