Local (subtree) scoping for suggest and AI search (#79) - #103
Merged
Conversation
Prepares workspace-local search end to end: - @solr-suggest accepts an optional path_prefix and filters with the same path_parents pattern the RAG retrieval already uses; with it the livesearch dropdown can honor a workspace scope (integration test included). - ragSearch and solrSearchSuggestions actions take an optional pathPrefix argument (backward compatible). - On the search page, a local search (local=true) now passes the path prefix to the AI retrieval too, so the answer's grounding matches the classic result list. The @Rag-Search backend already supported path_prefix. Frontend-only consumers decide the scope; without pathPrefix nothing changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revival of #100 (closed yesterday to keep local/global out of that delivery), rebased onto the current
feature-ai-rag. Consumed by the kitconcept.intranet workspace search dialog (internal ticket #426), where the Workspace chip acts as the local/global scope switch.@solr-suggestaccepts an optionalpath_prefixand filters with the samepath_parentspattern the RAG retrieval already uses — integration test included (TestSuggestPathPrefix).ragSearchandsolrSearchSuggestionsactions take an optionalpathPrefixargument (backward compatible).local=true) passes the path prefix to the AI retrieval too, so the answer's grounding matches the classic result list (@rag-searchalready supportedpath_prefix).searchPathPrefix(): an explicitpath_prefixURL param wins over thegetPathPrefixheuristic, which treats every single-segment path as a language root and silently dropped the prefix for top-level workspaces.Without
pathPrefix/path_prefixnothing changes for existing consumers.The intranet-side consumer (dialog scope switch + Cypress/unit tests) follows in a kitconcept.intranet PR that depends on this merge + a pin bump.