Skip to content

[MAINTENANCE] Adjust css class names in TOC Plugin#1846

Merged
sebastian-meyer merged 3 commits intokitodo:mainfrom
beatrycze-volk:toc-classes
Feb 23, 2026
Merged

[MAINTENANCE] Adjust css class names in TOC Plugin#1846
sebastian-meyer merged 3 commits intokitodo:mainfrom
beatrycze-volk:toc-classes

Conversation

@beatrycze-volk
Copy link
Collaborator

No description provided.

@beatrycze-volk beatrycze-volk self-assigned this Feb 11, 2026
@beatrycze-volk beatrycze-volk added the ⟳ maintenance A task to keep the code up-to-date and manageable. label Feb 11, 2026
Copy link
Member

@sebastian-meyer sebastian-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the renaming? Everybody who uses the default templates will have to adjust their CSS files...

@beatrycze-volk
Copy link
Collaborator Author

Because we use here mixed naming conventions:

<div class="tx-dlf-tableofcontents">
    <ul>
        <f:render partial="TableOfContents/Children" arguments="{children: toc, viewData: viewData}"/>
    </ul>
</div>

Ine the Main.html we have tx-dlf-tableofcontents, and then tx-dlf-toc. It would be good to unify it. It matches the standard approach where css classes are created 'tx-dlf-pluginname-xyz'.

Plus new names are more clear and descriptive.

Copy link
Member

@sebastian-meyer sebastian-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I'll try to remember to include a hint in the release notes. ;o)

@sebastian-meyer sebastian-meyer merged commit 2ac17af into kitodo:main Feb 23, 2026
10 of 14 checks passed
@codecov
Copy link

codecov bot commented Feb 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (894e254) to head (8612fd4).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@     Coverage Diff      @@
##   main   #1846   +/-   ##
============================
============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@beatrycze-volk beatrycze-volk deleted the toc-classes branch February 23, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⟳ maintenance A task to keep the code up-to-date and manageable.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants