Skip to content

fix: support different digest algorithms for pulling and storage#1130

Open
Arpit529Srivastava wants to merge 1 commit intokitops-ml:mainfrom
Arpit529Srivastava:digest-algo
Open

fix: support different digest algorithms for pulling and storage#1130
Arpit529Srivastava wants to merge 1 commit intokitops-ml:mainfrom
Arpit529Srivastava:digest-algo

Conversation

@Arpit529Srivastava
Copy link

Description

addressing the hardcoded sha256 digest directory paths introduced during the implementation of resumable downloads #408. while oci commonly defaults to sha256, the specification allows other algorithms (like sha512). this change updates the implementation to dynamically extract the digest algorithm from ocispec.Descriptor across the local repository stack, ensuring full oci compliance and compatibility with any valid hashing algorithm.

Linked issues

fixes #414

AI-Assisted Code

  • This PR contains AI-generated code that I have reviewed and tested
  • I take full responsibility for all code in this PR, regardless of how it was created

Signed-off-by: arpit529srivastava <arpitsrivastava529@gmail.com>
@Arpit529Srivastava
Copy link
Author

/cc @gorkem @amisevsk PTAL,
thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add tests to support different Digest algorithms

1 participant