Set python jsonschema version to 4.17.3 to avoid 4.18.x rust dependency#1331
Merged
kizniche merged 2 commits intokizniche:masterfrom Aug 21, 2023
Merged
Conversation
Owner
|
Thanks for the work and PR! I'll review shortly. |
Owner
|
Could you possibly add a short comment on the new requirements.txt line explaining why it's there, not to update the version, etc. so it's not accidentally changed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I installed Mycodo on a 32bit raspberry pi from both the latest release and master I see the following python dependency exception:
rpds-py is a dependency of jsonschema which is a dependency of flask-restx.
In version 4.18.x jsonschema added rust as a build dependency. Others had a similar issue here:
python-jsonschema/jsonschema#1143
Also wanted to throw out a thank you for all the work you have put into this project! It has been very interesting to work through your build instructions this last while. Keep it up and let me know if you have any questions.