Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SSL Certificate not trusted #1387

Closed
wants to merge 1 commit into from
Closed

Conversation

GlauxDe
Copy link

@GlauxDe GlauxDe commented Jul 4, 2024

Fix SSL certificate validity duration to prevent "not trusted" error on common browsers

Fix SSL certificate validity duration to prevent "not trusted" error on common browsers
Copy link

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kizniche
Copy link
Owner

kizniche commented Aug 1, 2024

And what occurs after 1 year and the certificate expires?

@mickeprag
Copy link

And what occurs after 1 year and the certificate expires?

Sound like a separate issue too me. The certificate must not be longer than one year to be valid.
https://support.apple.com/en-us/102028

@kizniche
Copy link
Owner

kizniche commented Sep 29, 2024

A 7 year old account creating its first pull request and requesting review?

@jimbo762
Copy link

A 7 year old account creating its first pull request and requesting review?

sounds legit :-)

@GlauxDe
Copy link
Author

GlauxDe commented Sep 29, 2024

A 7 year old account creating its first pull request and requesting review?

I’m sorry, I’m just trying to contribute… there seems to be an issue with the SSL certificate and I just wanted to point some attention to that. Thanks!

@jimbo762
Copy link

I dont believe any offense was meant, just an amusing observation.

@kizniche
Copy link
Owner

https://support.apple.com/en-us/102028
"This change will affect only TLS server certificates issued from the Root CAs preinstalled with iOS, iPadOS, macOS, watchOS, and tvOS"

This does not apply to self-signed certificates, like the one in question.

@kizniche kizniche closed this Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants