Skip to content

feat(DK): forking kit #2392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
unknownunknown1 wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

feat(DK): forking kit #2392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion contracts/src/arbitration/KlerosCore.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -871,7 +871,8 @@ contract KlerosCore is IArbitratorV2, Initializable, UUPSProxiable {
if (newCourtID != dispute.courtID) {
emit CourtJump(_disputeID, extraRoundID, dispute.courtID, newCourtID);
}

// TODO: forking kit logic.
// TODO: handle arbitration fees in case of Forking.
dispute.courtID = newCourtID;
dispute.period = Period.evidence;
dispute.lastPeriodChange = block.timestamp;
Expand Down Expand Up @@ -1196,6 +1197,7 @@ contract KlerosCore is IArbitratorV2, Initializable, UUPSProxiable {
// Court jump but not to the Forking court
return courts[newCourtID].feeForJuror * nbVotesAfterAppeal;
}
// TODO: forbid appeals once in Forking court.
return NON_PAYABLE_AMOUNT; // Jumping to the Forking Court is not supported yet.
}

Expand Down
1 change: 1 addition & 0 deletions contracts/src/arbitration/dispute-kits/DisputeKitClassic.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,6 +491,7 @@ contract DisputeKitClassic is IDisputeKit, Initializable, UUPSProxiable {

Dispute storage dispute = disputes[coreDisputeIDToLocal[_coreDisputeID]];
(uint256 finalRuling, , ) = core.currentRuling(_coreDisputeID);
// TODO: check if the final court is forking and if it is force the tie distribution for the last round.

for (uint256 i = 0; i < dispute.rounds.length; i++) {
Round storage round = dispute.rounds[i];
Expand Down
Loading
Loading