Conversation
JoonasKannisto
force-pushed
the
allow-ssl-errors
branch
from
e77b0be to
481ccef
Compare
jerbob92
left a comment
jerbob92
left a comment
There was a problem hiding this comment.
Thanks for the MR! Requested some changed.
Isn't this missing the iOS implementation as well?
src/platforms/android/java/com/klippa/NativeScriptHTTP/Async.java
Outdated
Show resolved
Hide resolved
jerbob92
left a comment
jerbob92
left a comment
There was a problem hiding this comment.
Thanks for the MR! Requested some changed.
Isn't this missing the iOS implementation as well?
|
Thanks for your comments, I made improvements to the code now. iOS is still missing. I'll make a separate pull request for it if I get it working. But this only adds it to the Android side. |
jerbob92
left a comment
jerbob92
left a comment
There was a problem hiding this comment.
Thanks for the update! Can you please add the iOS functionality to the same PR? I don't really see a good reason to merge in functionality which is missing iOS support.
README.md
Outdated
| * ** Only Android ** | ||
| */ | ||
| allowSslErrors(true); | ||
| export declare function enableSSLValidation(): void; |
There was a problem hiding this comment.
I think it's fine to keep only 1 method, I just wanted it renamed
| InitClient(); | ||
|
|
||
| try { | ||
| TrustManagerFactory trustManagerFactory = TrustManagerFactory.getInstance(TrustManagerFactory.getDefaultAlgorithm()); |
There was a problem hiding this comment.
My intention was to do this inside InitClient while building the client, but before running client.build()
JoonasKannisto
force-pushed
the
allow-ssl-errors
branch
from
53f2d2e to
7b8af78
Compare
|
I've now finishe iOS side of it. |
|
@jerbob92 Hi. Sorry to bother you here as well, but do you have time to review my iOS changes? |
2 participants
PR Checklist
What is the current behavior?
Does not allow SSL errors or self-signed certificates
What is the new behavior?
Enables allowing ssl errors and self-signed certificates
Fixes/Implements/Closes #99.