Skip to content

Conversation

@matejvasek
Copy link
Contributor

@matejvasek matejvasek commented Aug 7, 2025

Changes

  • 🐛 All tekton tasks have identical workspace list/set.

/kind bug

fix: affinity/coscheduling issues of tekton tasks

@knative-prow
Copy link

knative-prow bot commented Aug 7, 2025

@matejvasek: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Workspace set must be identical for all the tasks. Having strict subset of workspaces clearly does not work.

Changes

/kind

Fixes #

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot requested review from dsimansk and nainaz August 7, 2025 12:16
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 7, 2025
@jrangelramos
Copy link
Contributor

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2025
@codecov
Copy link

codecov bot commented Aug 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.30%. Comparing base (aeb51b3) to head (be429f2).
⚠️ Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2972      +/-   ##
==========================================
+ Coverage   58.93%   59.30%   +0.36%     
==========================================
  Files         132      132              
  Lines       16935    16956      +21     
==========================================
+ Hits         9981    10055      +74     
+ Misses       6025     5942      -83     
- Partials      929      959      +30     
Flag Coverage Δ
e2e-tests 33.33% <0.00%> (-6.31%) ⬇️
integration-tests 54.51% <100.00%> (+1.74%) ⬆️
unit-tests 46.68% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Workspace set must be identical for all the tasks.
Having strict subset of workspaces clearly does not work.

Signed-off-by: Matej Vašek <[email protected]>
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2025
@matejvasek
Copy link
Contributor Author

plz re-lgtm @jrangelramos

Signed-off-by: Matej Vašek <[email protected]>
@matejvasek
Copy link
Contributor Author

/test unit-tests

Signed-off-by: Matej Vašek <[email protected]>
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2025
@lkingland
Copy link
Member

lkingland commented Sep 5, 2025

The GitHub UI does not have rerunning the tests as an option.
Perhaps submitting a rebase will get it un-stuck?

@knative-prow
Copy link

knative-prow bot commented Sep 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lkingland,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants