-
Couldn't load subscription status.
- Fork 1.2k
Allow using serve mode with system-internal-tls #16183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
When system-internal-tls is enabled, the KPA reconciler now checks the SystemInternalTLSAllowServeMode flag to determine whether to use serve mode or force proxy mode. This allows configurations where internal TLS is enabled but serve mode is still desired.
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: linkvt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16183 +/- ##
==========================================
- Coverage 80.06% 80.02% -0.05%
==========================================
Files 214 214
Lines 16940 16941 +1
==========================================
- Hits 13563 13557 -6
- Misses 3019 3023 +4
- Partials 358 361 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hi,
related PR in networking: knative/networking#1093
Proposed Changes
Release Note
Questions:
Thanks for the feedback!
/kind enhancement
/cc @Fedosin