Skip to content

Allow manual scaling of the Pod Autoscaler #16186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Allow manual scaling of the Pod Autoscaler #16186

wants to merge 12 commits into from
+363 −70

Conversation

@dprotaso
Copy link
Member

  • Exclude autoscaling annotations from everything but the KPA
  • propagate annotation updates to the Pod Autoscaler

@dprotaso
Exclude autoscaling annotations from everything but the KPA
0a226a7 
When creating child resources for a Revisino we now exclude
propagating autoscaling annotations. The exception is the KPA
for which we do propagate annotations.
@dprotaso
propagate annotation updates to the Pod Autoscaler
6c3267f
@knative-prow knative-prow bot requested review from dsimansk, linkvt and skonto October 22, 2025 03:09
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 22, 2025
@knative-prow
Copy link

knative-prow bot commented Oct 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2025
@dprotaso dprotaso changed the title Allow manual scaling of the Pod Autoscaler [wip] Allow manual scaling of the Pod Autoscaler Oct 22, 2025
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 22, 2025
@dprotaso dprotaso mentioned this pull request Oct 22, 2025
Closed
@dprotaso dprotaso added this to the v1.20.0 milestone Oct 22, 2025
@codecov
Copy link

codecov bot commented Oct 22, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 79.36508% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.08%. Comparing base (54868c2) to head (182581e).
⚠️ Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
pkg/testing/functional.go 0.00% 9 Missing ⚠️
pkg/reconciler/revision/reconcile_resources.go 88.57% 2 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##             main   #16186     +/-   ##
=========================================
  Coverage   80.08%   80.08%             
=========================================
  Files         214      214             
  Lines       16940    13313   -3627     
=========================================
- Hits        13566    10662   -2904     
+ Misses       3015     2292    -723     
  Partials      359      359

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dprotaso
Propagate the KPA status even when updating the KPA fails
f3512f1 
Otherwise if the update fails this can have a side-effect of
marking a revision as ready.

Specifically when a Deployment has >1 ready Pods it'll mark the
Revision as Ready. It's the KPA status propagation that will mark
the revision still deploying when it hasn't reached min-scale.
@dprotaso
don't remove annotations that are added by defaulting/webhooks
0cfd5df
@dprotaso
tweak diff output so we don't see defaulted values always being added
9c5da28
dprotaso
dprotaso commented Oct 23, 2025
View reviewed changes
@dprotaso dprotaso modified the milestones: v1.20.0, v1.21.0 Oct 27, 2025
@dprotaso
Copy link
Member Author

I don't want to merge this the day before the release - moving to the next one

@dprotaso dprotaso changed the title [wip] Allow manual scaling of the Pod Autoscaler Allow manual scaling of the Pod Autoscaler Oct 27, 2025
@dprotaso
Copy link
Member Author

/hold

@knative-prow knative-prow bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Oct 27, 2025
@dprotaso
Copy link
Member Author

/hold cancel

release is done

/assign @Fedosin @linkvt @nader-ziada

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 30, 2025
@dprotaso
Copy link
Member Author

/retest

Webhook flake

linkvt
linkvt reviewed Oct 31, 2025
View reviewed changes
Copy link

@linkvt linkvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me besides the small comment I made 👍
I'll leave the approve to someone with more experience though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@linkvt linkvt linkvt left review comments

@dsimansk dsimansk Awaiting requested review from dsimansk

@skonto skonto Awaiting requested review from skonto

Assignees

@linkvt linkvt

@nader-ziada nader-ziada

@Fedosin Fedosin

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v1.21.0

Development

Successfully merging this pull request may close these issues.

4 participants

@dprotaso @linkvt @nader-ziada @Fedosin