fix(desktop): bundle version-major shipping RPC handlers - #6971
Open
yzxcj797 wants to merge 2 commits into
Open
Conversation
|
@yzxcj797 is attempting to deploy a commit to the World Monitor Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
api/{domain}/v{major}/[rpc].tsandapi/v{major}/{domain}/[rpc].ts.Fixes #5907
Testing
node scripts/build-sidecar-handlers.mjsreported 34 domains and emitted noapi/v2/shipping/[rpc].js; the new regression failed.node --test tests/build-sidecar-handlers.test.mjs— 2 passed.npm run test:sidecar— 395 passed.npx tsx --test tests/shipping-v2-handler.test.mjs— 29 passed (existing auth, tenant-isolation, SSRF, and secret-redaction coverage).npm run typecheck:all— passed.npm run lint— passed (repository-wide warnings are pre-existing); targeted Biome check on changed script/test files passed.npm run lint:api-contractandnpm run lint:boundaries— passed.npm run security:local-env-dumpsandnpm run security:vite-env-secrets— passed.git diff --check— passed.Security review
[rpc].tspaths, performs no network requests, evaluates no external input, and does not introduce dynamic module loading.