Repository navigation
fix(release): wait for a cached npm tarball 404 after publish - #69
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.7.0 release failed in
npm-publish. The npm CDN briefly served a cached 404 for the just-published Linux tarball, andbuild_npm.pyraised on that 404 instead of waiting, as it already does for the version metadata. Both registry reads now share one helper, which turns a 404 into "not visible yet" inside the existing 1,200 s visibility deadline. Other HTTP errors still fail at once, and the byte and integrity checks are unchanged.Validation: a new regression reproduces the stale-404 sequence (it failed before the fix with the same HTTPError), and a second test keeps a tarball 500 failing immediately.
tests/test_npm_distribution.py: 98 passed.tests/test_release_assets.py: 127 passed.