Repository navigation
feat(url): verify TLS with the OS and read embedded data from JavaScript shells - #70
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--urlnow verifies TLS with the operating system's certificate verifier throughtruststore==0.10.5(MIT, pure Python, no dependencies, owner-approved). Pages whose root is only in the OS store, such as GlobalSign Root R46 on macOS, now load the way they do in a browser. When a page is still a JavaScript shell after static or JS capture, brewdoc builds a partialembedded_datasnapshot from the title, description, JSON-LD text and noscript blocks of the static HTML. This happens only when that text reaches 200 characters; otherwise the refusal stays as before. AWS WAF challenge pages are namedaws-waf. Version 0.7.1. Closes #68.Pilots: truststore recovered the 3 TLS-refused bench pages with no change on the other 49 https URLs. Expired, wrong-host and self-signed certificates still refuse at
tls. The embedded-data rule recovers real text on 3 of 12 live shells (Airbnb, SoundCloud, Bluesky); slogan-only shells such as crates.io still refuse.Validation: new offline regressions for each change. Non-corpus suite: 2593 passed. Self-check passes. Live checks: finmarket USD converts, and self-signed.badssl.com refuses at
tls.