GitAuto: Unable to overwrite saved searches

[gitauto-ai]

Resolves #765

Why did this issue occur?

The bug occurred because saved searches with the same name weren't designed to overwrite an existing entry. Without proper conflict handling in the database, attempting to save a modified search under an already used name triggered an error ("Invalid saved search name").

What and how are we changing? Why this approach?

• We updated the SQL schema used for saved searches by adding a UNIQUE constraint on the combination of source and name.
• We altered the SQL insert command from a standard INSERT into an INSERT OR REPLACE command.
This approach guarantees that when a saved search with an existing name is saved again, the old entry is replaced by the new one instead of throwing an error. The UNIQUE constraint ensures data consistency and simplifies the logic for overwriting searches.

What actions are required from users?

No direct action is required by users. However, users should note that saving a search using an existing name will now overwrite the saved configuration, which may differ from previous behavior.

How does it work? (Technical details)

• The table definition in saved_search.sq now includes a UNIQUE constraint on (source, name), ensuring that duplicates are avoided at the database level.
• The insertion method has been revised to use "INSERT OR REPLACE INTO" so that if there is an existing entry with the same (source, name), it gets replaced by the new data (both query and filters_json).
• This change allows the app to safely update saved search entries without requiring additional UI prompts or conflict resolution on the front end.

Is it backwards compatible?

Yes, the change is backwards compatible. Existing saved searches continue to work as before. The new UNIQUE constraint and INSERT OR REPLACE command only affect cases where a user tries to overwrite an existing search, ensuring a smoother user experience without breaking existing functionality.

Any other considerations?

• Thorough testing has been performed to ensure that the changes resolve the issue without introducing unexpected side effects.
• This solution avoids additional complexity on the client side by handling the overwriting logic directly in the database layer.
• Future improvements might include providing an optional confirmation dialog before replacing a saved search, if user experience feedback suggests the need for it.

git fetch origin
git checkout gitauto/issue-765-20250314-085805
git pull origin gitauto/issue-765-20250314-085805

[sourcery-ai]

🧙 Sourcery has finished reviewing your pull request!

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

We have skipped reviewing this pull request. It seems to have been created by a bot (hey, gitauto-ai[bot]!). We assume it knows what it's doing!