Skip to content

Conversation

@gcar-bendingspoons
Copy link

@gcar-bendingspoons gcar-bendingspoons commented Oct 16, 2025

When dumping to JSON, support loading the data from a Nominatim dump instead of the database.

The goal of this change is to preprocess the JSON data dumps available from Graphhopper before importing in Komoot search service.

  • Update README with new -json <output filename> -input-file <nominatim dump filename>
  • Separate PR for adding the address type to the output

@gcar-bendingspoons gcar-bendingspoons self-assigned this Oct 16, 2025
@coderabbitai
Copy link

coderabbitai bot commented Oct 16, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch dump-from-file

Comment @coderabbitai help to get the list of available commands and usage tips.

@lonvia
Copy link
Collaborator

lonvia commented Oct 17, 2025

I don't understand what you want to do here. If you need to preprocess the JSON dumps you can do that with any other tool that can process json before importing them to Photon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants