Тимур Бабаев

TagCloud/Colors/Factories/WordColorizerFactory.cs

@@ -8,15 +8,13 @@ public class WordColorizerFactory(IIndex<string, IWordColorizerCreator> creators
 {
     public Result<IWordColorizer> Create(TagCloudOptions options)
     {
-        return Result.Of(() =>
-        {
-            if (string.IsNullOrWhiteSpace(options.ColorizerName))
-                return Result.Fail<IWordColorizer>("Colorizer name not specified");
+        if (string.IsNullOrWhiteSpace(options.ColorizerName))
+            return Result.Fail<IWordColorizer>("Colorizer name not specified");
 
-            if (!creators.TryGetValue(options.ColorizerName, out var creator))
-                return Result.Fail<IWordColorizer>($"Colorizer {options.ColorizerName} not found");
+        if (!creators.TryGetValue(options.ColorizerName, out var creator))
+            return Result.Fail<IWordColorizer>($"Colorizer {options.ColorizerName} not found");
 
-            return creator.Create(options);
-        }).Then(x => x);
+        return creator.Create(options)
+            .Then(Result.Ok);
     }
 }

TagCloud/ResultModel/Result.cs

@@ -33,6 +33,7 @@ public static Result<T> Ok<T>(T value)
     {
         return new Result<T>(null, value);
     }
+
     public static Result<None> Ok()
     {
         return Ok<None>(null);

TagCloudTests/ResultTests.cs

@@ -0,0 +1,80 @@
+using FluentAssertions;
+using TagCloud.ResultModel;
+
+namespace TagCloudTests;
+
+public class ResultTests
+{
+    [Test]
+    public void Ok_ShouldBeSuccessAndContainValue_WhenValueIsProvided()
+    {
+        var result = Result.Ok(52);
+
+        result.IsSuccess.Should().BeTrue();
+        result.GetValueOrThrow().Should().Be(52);
+    }
+
+    [Test]
+    public void Fail_ShouldNotBeSuccessAndContainError_WhenErrorIsProvided()
+    {
+        var result = Result.Fail<int>("some error");
+
+        result.IsSuccess.Should().BeFalse();
+        result.Error.Should().Be("some error");
+    }
+
+    [Test]
+    public void GetValueOrThrow_ShouldThrow_WhenFail()
+    {
+        var result = Result.Fail<int>("error");
+
+        Action action = () => result.GetValueOrThrow();
+
+        action.Should().Throw<InvalidOperationException>();
+    }
+
+    [Test]
+    public void Then_ShouldTransformValue_WhenSuccess()
+    {
+        var result = Result.Ok(3)
+            .Then(x => x * 3);
+
+        result.IsSuccess.Should().BeTrue();
+        result.GetValueOrThrow().Should().Be(9);
+    }
+
+    [Test]
+    public void Then_ShouldNotCallNextAction_WhenFail()
+    {
+        var isCalled = false;
+
+        var result = Result.Fail<int>("error")
+            .Then(x =>
+            {
+                isCalled = true;
+                return x * 2;
+            });
+
+        result.IsSuccess.Should().BeFalse();
+        isCalled.Should().BeFalse();
+    }
+
+    [Test]
+    public void Of_ShouldCatchExceptionAndReturnFail_WhenExceptionIsInside()
+    {
+        var result = Result.Of<int>(() => throw new Exception("error"));
+
+        result.IsSuccess.Should().BeFalse();
+        result.Error.Should().Contain("error");
+    }
+
+    [Test]
+    public void RefineError_ShouldPrefixErrorMessage()
+    {
+        var result = Result.Fail<int>("error")
+            .RefineError("refined error");
+
+        result.IsSuccess.Should().BeFalse();
+        result.Error.Should().Be("refined error. error");
+    }
+}