feat(web): complete app localization and add Serbian - #7109
Draft
markokraemer wants to merge 33 commits into
Draft
feat(web): complete app localization and add Serbian#7109markokraemer wants to merge 33 commits into
markokraemer wants to merge 33 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Preview environment - live and tested
The preview owns PostgreSQL, Supabase, API, gateway, frontend, and Mailpit. OAuth initiation is the only explicit preview exclusion. |
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
markokraemer
added
preview
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The web app exposed eight languages, but locale coverage was incomplete. Serbian was absent. Many rendered strings bypassed the catalogs. Dynamic JSX templates and technical attributes also escaped the previous audit.
Changes
sr.I18nProvider.<html lang>, settings tabs, settings content, keyboard shortcuts, and five onboarding steps.tests/spec/end-to-end.md.Local verification
pnpm i18n:auditfromapps/web: nine catalogs; 17,163 keys each; 0 missing; 0 extra; 0 invalid; 0 hardcoded findings.bun test scripts/audit-i18n.test.mjsfromapps/web: 1 passed; 0 failed.bun test src/i18nfromapps/web: 10 passed; 0 failed; 160,084 assertions.E2E_GREP="each supported locale persists and renders" pnpm test -- --browser-only: 1 passed in 2.9 minutes.pnpm test -- --full: all 19 journeys passed in 317.2 seconds.@types/buntest declaration errors.git diff --check: passed.The full package-quality lane exposed existing concurrency flakes. Each affected CLI and
kortixdsuite passed when rerun alone.Preview verification
Preview: https://8080-01m1nktqrg4m6wd0edq76aqe0h.eu-west.sbx.platinum.dev
Workflow: https://github.com/kortix-ai/suna/actions/runs/33851221249
Commit:
0443ba231ebc7131318e49e0a884ac1450fc6019/healthreturns HTTP 200.0443ba231ebc7131318e49e0a884ac1450fc6019.pnpm test -- --target-fullpassed on the isolated preview.СрпскиsendsPUT /auth/v1/userand receives HTTP 200.sr.<html lang="sr">.Kortix – AI командни центар за вашу компанију.Review note
Catalog structure, runtime rendering, locale persistence, and deployed browser behavior are verified. Native-language copy has not received human linguistic review across all 154,467 catalog values.
Delivery state
Draft. The branch is ready for review. Do not merge without explicit user approval.