perf diff: Introduce the new rules of colored printing of delta.#147
Open
perf diff: Introduce the new rules of colored printing of delta.#147
Conversation
As you know, there are the common colored printing of percents so overhead(%) can be colored with the rule. But Delta means difference percents from percents of overhead between two files e.g. perf.data and perf.data.old. Although the rule is for overhead(%), Delta value also follow the same rule. So, I think that it would be better to use the new colored rule for the Delta as below. Increament: background colored in red (e.g. +0.50%) Decrement: colored in blue (e.g. -5.50%) Same: default color (e.g. +0.00%) Instead of percent_color_snprintf() function, use new delta_color_snprintf() function. Signed-off-by: SeongSoo Cho <nexusz99@gmail.com> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Jiri Olsa <jolsa@kernel.org> Cc: Taeung Song <taeung@kosslab.kr>
ppiyakk2
force-pushed
the
perf/diff_delta_color
branch
from
9b21d66 to
41c7681
Compare
Collaborator
|
I also think so. Using the new colored rule for the Delta can help us to realize variation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As you know, there are the common colored printing of percents so overhead(%) can be colored with the rule.
But Delta means difference percents from percents of overhead between two files e.g. perf.data and perf.data.old.
Although the rule is for overhead(%), Delta value also follow the same rule.
So, I think that it would be better to use the new colored rule for the Delta as below.
Increament: background colored in red (e.g. +0.50%)
Decrement: colored in blue (e.g. -5.50%)
Same: default color (e.g. +0.00%)
Instead of percent_color_snprintf() function, use new delta_color_snprintf() function.
Signed-off-by: SeongSoo Cho nexusz99@gmail.com
Cc: Namhyung Kim namhyung@kernel.org
Cc: Jiri Olsa jolsa@kernel.org
Cc: Taeung Song taeung@kosslab.kr