Pull function-catalog to have all docs in the same domain #4289
Conversation
✅ Deploy Preview for kptdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Now you can see function-catalog in the same domain |
|
|
||
| .PHONY: serve production-build preview-build fetch-external-docs | ||
|
|
||
| fetch-external-docs: |
There was a problem hiding this comment.
Also copy the examples folder from $(CLONE_DIR) to content/en/examples
There was a problem hiding this comment.
@CsatariGergely I added them now.
Thank you because I did not notice they were not getting rendered
|
Looks good, thanks. Is there a way to trigger the build of kpt.dev in case there is a change in krm-functions-catalog? |
Right, I haven't thought of this I am reading from docs we should use this build hook https://docs.netlify.com/build/configure-builds/build-hooks/ I can generate a PR for the catalog repo, but an OWNER might need to create a secret with the netlify build hook url from kpt.dev site (kpt.dev site on Netlify: Site settings -> Build & deploy -> Build hooks) |
@CsatariGergely kptdev/krm-functions-catalog#1187 added this, but I am assuming an OWNER can create that variable |
Signed-off-by: lapentafd <[email protected]>
Signed-off-by: lapentafd <[email protected]>
Signed-off-by: lapentafd <[email protected]>
lapentad
force-pushed
the
custom-build-script-netlify
branch
from
71447f6 to
84a8f49
Compare
Signed-off-by: lapentafd <[email protected]>
Signed-off-by: lapentafd <[email protected]>
2 participants
The makefile will clone the function catalog repo and copy over only function runner folder doc and it's javascript