Skip to content

ci: verify documentation/go.sum integrity#4531

Merged
efiacor merged 1 commit into
kptdev:mainfrom
Nordix:ci/verify-docs-go-sum
May 21, 2026
Merged

ci: verify documentation/go.sum integrity#4531
efiacor merged 1 commit into
kptdev:mainfrom
Nordix:ci/verify-docs-go-sum

Conversation

@efiacor
Copy link
Copy Markdown
Contributor

@efiacor efiacor commented May 21, 2026

Summary

Adds a GitHub Actions workflow that checks documentation/go.sum on PRs touching documentation/:

  1. Fails if go.sum is empty — prevents accidental stripping during Go version bumps
  2. Runs go mod verify — ensures checksums match downloaded modules

Motivation

PR #4519 accidentally emptied documentation/go.sum when upgrading Go versions. This happened because go mod tidy with newer Go can strip entries for Hugo-only modules. This CI check catches that before merge.

What was tested

  • Verified the workflow YAML is valid
  • Confirmed go mod verify passes against the current documentation/ module

@efiacor efiacor requested a review from liamfallon as a code owner May 21, 2026 08:06
Copilot AI review requested due to automatic review settings May 21, 2026 08:06
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label May 21, 2026
@netlify
Copy link
Copy Markdown

netlify Bot commented May 21, 2026

Deploy Preview for kptdocs ready!

Name Link
🔨 Latest commit 3b36040
🔍 Latest deploy log https://app.netlify.com/projects/kptdocs/deploys/6a0ebf920d81fa00082e48de
😎 Deploy Preview https://deploy-preview-4531--kptdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds CI guardrails to prevent accidental corruption of the documentation/ Go module dependency checksums (especially documentation/go.sum) when PRs modify documentation.

Changes:

  • Introduces a new GitHub Actions workflow triggered on documentation/** changes (PRs and pushes to main).
  • Fails CI if documentation/go.sum is missing/empty.
  • Runs go mod verify in documentation/ to validate module checksum integrity.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/verifyDocumentation.yml Outdated
Adds a CI check that fails if documentation/go.sum is empty or
inconsistent with go.mod. This prevents accidental stripping of
the checksum file during Go version upgrades.

Signed-off-by: Fiachra <fiachra@nordix.org>
Signed-off-by: Fiachra Corcoran <fiachra.corcoran@est.tech>
@efiacor efiacor force-pushed the ci/verify-docs-go-sum branch from a184621 to 3b36040 Compare May 21, 2026 08:17
@efiacor efiacor closed this May 21, 2026
@efiacor efiacor reopened this May 21, 2026
@dosubot dosubot Bot added the lgtm label May 21, 2026
@efiacor efiacor merged commit cafd4d2 into kptdev:main May 21, 2026
14 of 22 checks passed
@efiacor efiacor deleted the ci/verify-docs-go-sum branch May 21, 2026 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/devops lgtm size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants