Fix import on cmdcat command.go#4535
Merged
Merged
Conversation
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon
requested review from
efiacor,
kispaljr and
mozesl-nokia
as code owners
✅ Deploy Preview for kptdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
dosubot
Bot
added
size:XS
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a build-breaking import in the cmdcat command by switching from a removed/invalid internal import to the canonical args utility package.
Changes:
- Replace the
internal/util/argutilimport withpkg/lib/util/argsand update the call site accordingly. - Minor test refactor to use integer
rangeiteration. - Remove now-unneeded
github.com/docker/distributionentries fromgo.sum.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| thirdparty/cmdconfig/commands/cmdcat/cmdcat.go | Updates symlink resolution to use pkg/lib/util/args (fixes broken import). |
| thirdparty/cmdconfig/commands/cmdcat/cmdcat_test.go | Refactors a file-generation loop to use for i := range 500. |
| go.sum | Cleans up unused github.com/docker/distribution checksum entries. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
efiacor
approved these changes
May 21, 2026
aravindtga
approved these changes
May 21, 2026
mozesl-nokia
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an incorrect import that breaks the kpt build.