Skip to content

chore: upgrade plaited to 7.0.0 #1862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 19, 2025
Merged

Conversation

EdwardIrby
Copy link
Contributor

Upgrades plaited library to version 7.0.0

@krausest
Copy link
Owner

Sorry, after rebuilding I'm getting the following error in the console:

main.js:1 Uncaught TypeError: Cannot read properties of undefined (reading 'render')
    at Object.run (main.js:1:13373)
    at main.js:1:2948
    at t (main.js:1:1157)
    at c (main.js:1:2564)
    at i (main.js:1:2375)
    at o (main.js:1:2004)
    at s (main.js:1:1830)
    at trigger (main.js:1:2862)
    at O.callback (main.js:1:4959)
    at O.handleEvent (main.js:1:4608)

Can you take a look at it please?

@EdwardIrby
Copy link
Contributor Author

Sorry, after rebuilding I'm getting the following error in the console:

main.js:1 Uncaught TypeError: Cannot read properties of undefined (reading 'render')
    at Object.run (main.js:1:13373)
    at main.js:1:2948
    at t (main.js:1:1157)
    at c (main.js:1:2564)
    at i (main.js:1:2375)
    at o (main.js:1:2004)
    at s (main.js:1:1830)
    at trigger (main.js:1:2862)
    at O.callback (main.js:1:4959)
    at O.handleEvent (main.js:1:4608)

Can you take a look at it please?

Should be fixed now

@krausest krausest merged commit 17da976 into krausest:master Apr 19, 2025
@krausest
Copy link
Owner

Here are the results. Left updated keyed results, on the right previous results:
Screenshot 2025-04-20 at 09 29 31
I'm afraid it looks like a performance regression.

@EdwardIrby
Copy link
Contributor Author

Here are the results. Left updated keyed results, on the right previous results: Screenshot 2025-04-20 at 09 29 31 I'm afraid it looks like a performance regression.

I ended up fixing this regression in #1875. Thanks for calling that out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants