Skip to content

update pota #1890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025
Merged

update pota #1890

merged 1 commit into from
Jun 19, 2025

Conversation

titoBouzout
Copy link
Contributor

@titoBouzout titoBouzout commented Jun 13, 2025

Ive restructured the project and added typings. It defaults to attributes instead of properties to align better with html.

Of relevance, it uses usePrevious instead of useSelector which performs better for the case at hand. And have added some data- attributes, I'm not sure if this will cause any problems.

Im unsure why the whitespace changed, its supposed to follow the prettier config from the package.json. This link is better https://github.com/krausest/js-framework-benchmark/pull/1890/files?diff=unified&w=1

Thanks!

@krausest krausest merged commit a41bc76 into krausest:master Jun 19, 2025
@krausest
Copy link
Owner

Thanks, here's the comparison (updated keyed version left, old version right):
Screenshot 2025-06-20 at 08 10 05
Looks like a small improvement (but there's not much to shave off).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants