Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add function_variables key in JSON validation #73

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

khansaad
Copy link
Contributor

@khansaad khansaad commented Jul 5, 2022

Signed-off-by: Saad Khan [email protected]

This PR adds the function_variables key back in the search space JSON which was failing the validation process.
The function_variables key was removed earlier as part of the feature enhancement under issue #30 where we have planned to separate this and the objective function in a different API.

@khansaad khansaad self-assigned this Jul 5, 2022
@khansaad khansaad requested review from chandrams and dinogun July 5, 2022 07:09
Copy link
Contributor

@dinogun dinogun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dinogun dinogun merged commit 25820f1 into kruize:main Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants