Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add SCC files for running HPO in a restricted manner #95

Merged
merged 2 commits into from
Aug 9, 2022

Conversation

khansaad
Copy link
Contributor

@khansaad khansaad commented Aug 9, 2022

This PR intends to solve the issue #94

Create a SCC file to in which relevant constraints are added.
Add the specific userID in the deployment.yaml_template who will have the access same as the one in dockerfile
Add service account and rolebinding to link the SCC.

Signed-off-by: Saad Khan [email protected]
Signed-off-by: Saad Khan [email protected]

@khansaad
Copy link
Contributor Author

khansaad commented Aug 9, 2022

Sanity Test Results

########### Results Summary of the test suite hpo_api_tests ##########
hpo_api_tests took 220 seconds
Number of tests performed 1
Number of tests passed 1
Number of tests failed 0

~~~~~~~~~~~~~~~~~~~~~~ hpo_api_tests passed ~~~~~~~~~~~~~~~~~~~~~~~~~~

************************************** done *************************************

*********************************************************************************
~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Overall summary of the tests ~~~~~~~~~~~~~~~~~~~~~~~
Total time taken to perform the test 220 seconds
Total Number of test suites performed 1
Total Number of tests performed 1
Total Number of tests passed 1
Total Number of tests failed 0

*********************************************************************************
########################################################################

@khansaad khansaad marked this pull request as ready for review August 9, 2022 07:53
@khansaad khansaad requested review from chandrams and dinogun August 9, 2022 07:54
@chandrams
Copy link
Contributor

I have tested on openshift, all tests worked fine except grpc which has an open issue #77

Copy link
Contributor

@chandrams chandrams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dinogun dinogun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work to get this all figured out! LGTM

@dinogun dinogun merged commit b67bde8 into kruize:main Aug 9, 2022
@khansaad khansaad linked an issue Aug 10, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create SCC for running HPO on Openshift in restricted manner
3 participants