Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and expand manual tests with auth repo #403

Closed

Conversation

rocketraman
Copy link

The manual tests for an authenticated repo were not complete.

Fixed the test artifactory server startup.

Added a test for environment variable substitution (test 4). Note that this test follows the current documentation in the README of using {{FOO}} style env var substitutions, but that will not currently work. What will work is $FOO. This should be updated as part of the fix for #402.

Added a test for environment variable substitution with packaging (test 5). This test will not currently work as the substituted credentials are not passed to Gradle properly by kscript.

NOTE: Instead of this being a manual test, it could be done in an automated unit test with Testcontainers.

@rocketraman
Copy link
Author

Closing, will submit a single PR with all related changes.

@rocketraman rocketraman deleted the rg/fix-manual-tests branch June 22, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant