Skip to content

Mscorlib features#34

Open
raysplaceinspace wants to merge 3 commits intokswoll:masterfrom
raysplaceinspace:mscorlib-features
Open

Mscorlib features#34
raysplaceinspace wants to merge 3 commits intokswoll:masterfrom
raysplaceinspace:mscorlib-features

Conversation

@raysplaceinspace
Copy link

This pull request just contains additions/fixes to mscorlib:

  • .NET AddMonths and JavaScript AddMonths was working differently. Made the JavaScript one work the same as .NET, and wrote tests to cover this. This was quite important for us - we needed to have C# and JavaScript work identically for this project to be useful.
  • Addition assignment of TimeSpans to DateTimes wasn't working (it'd do the addition but not the assignment). Fixed that. See the unit test for an example.
  • Added some features we were using in C# that weren't already in mscorlib (another overload of ArgumentException, as well as AssemblyInformationalVersionAttribute)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant