Skip to content

Fix kustomize5 warnings #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Fix kustomize5 warnings #688

wants to merge 8 commits into from
+38 −30

Conversation

vikas-saxena02
Copy link

As per the milestone to fix kustomize warnings as indicated in kubeflow/manifests#2991, this PR aims at fixing the same in mpi-operator repo

@google-oss-prow google-oss-prow bot requested review from carmark and gaocegege March 29, 2025 19:42
@vikas-saxena02
Copy link
Author

/retest

@vikas-saxena02
Copy link
Author

diff -u for manifests/overlays/standalone/
Screenshot 2025-03-30 at 6 58 11 am

@vikas-saxena02
Copy link
Author

diff -u for manifests/overlays/kubeflow/
Screenshot 2025-03-30 at 7 03 09 am

@vikas-saxena02
Copy link
Author

diff -u for manifests/base/
Screenshot 2025-03-30 at 7 05 09 am

@vikas-saxena02
Copy link
Author

vikas-saxena02 commented Mar 29, 2025 •
edited
Loading

@juliusvonkohout no difference in renedered yaml shown by diff -u. I have provided screenshots for the same. I will work on fixing the failing checks

@vikas-saxena02
Copy link
Author

vikas-saxena02 commented Mar 29, 2025 •
edited
Loading

@tenzen-y can I please get some help in identifying the root cause of the checks failed above. I just checked some other open PRs and they also seem to have the same checks failed

@vikas-saxena02 vikas-saxena02 mentioned this pull request Mar 29, 2025
Open
@vikas-saxena02 vikas-saxena02 force-pushed the fix_kustomize5_warnings branch from a88eb8c to 4ed4cd2 Compare April 11, 2025 02:50
@tenzen-y
Copy link
Member

@tenzen-y can I please get some help in identifying the root cause of the checks failed above. I just checked some other open PRs and they also seem to have the same checks failed

#692 will fix CI errors.

@vikas-saxena02
Copy link
Author

@tenzen-y can I please get some help in identifying the root cause of the checks failed above. I just checked some other open PRs and they also seem to have the same checks failed

#692 will fix CI errors.

Hi @tenzen-y i also managed to fix them in my branch this avro... i just saw #692 and we have same changes

@tenzen-y
Copy link
Member

@tenzen-y can I please get some help in identifying the root cause of the checks failed above. I just checked some other open PRs and they also seem to have the same checks failed

#692 will fix CI errors.

Hi @tenzen-y i also managed to fix them in my branch this avro... i just saw #692 and we have same changes

Oh, I didn't find that. Could you rebase this PR?

@vikas-saxena02
Copy link
Author

/hold

@vikas-saxena02
# This is a combination of 4 commits.
84269a7 
# This is the 1st commit message:

fixed based with kustomize edit fix

Signed-off-by: Vikas Saxena <[email protected]>

# This is the commit message kubeflow#2:

fixed overlays/kubeflow with kustomize edit fix

Signed-off-by: Vikas Saxena <[email protected]>

# This is the commit message kubeflow#3:

fixed overlays/standalone with kustomize edit fix

Signed-off-by: Vikas Saxena <[email protected]>

# This is the commit message kubeflow#4:

updated gpg signature for intel image

Signed-off-by: Vikas Saxena <[email protected]>
@vikas-saxena02
fixed based with kustomize edit fix
1e03a26 
Signed-off-by: Vikas Saxena <[email protected]>

fixed overlays/kubeflow with kustomize edit fix

Signed-off-by: Vikas Saxena <[email protected]>

fixed overlays/standalone with kustomize edit fix

Signed-off-by: Vikas Saxena <[email protected]>

updated gpg signature for intel image

Signed-off-by: Vikas Saxena <[email protected]>

updating new intel oneAPI key

Signed-off-by: Vikas Saxena <[email protected]>

replacing curl by wget as the underling image doesnt have curl

Signed-off-by: Vikas Saxena <[email protected]>
@vikas-saxena02
resolving merge cnflicts in intel.Dockerfile 4
0c331b7 
Signed-off-by: Vikas Saxena <[email protected]>
@vikas-saxena02
# This is a combination of 5 commits.
c1a7252 
# This is the 1st commit message:

fixed based with kustomize edit fix

Signed-off-by: Vikas Saxena <[email protected]>

fixed overlays/kubeflow with kustomize edit fix

Signed-off-by: Vikas Saxena <[email protected]>

fixed overlays/standalone with kustomize edit fix

Signed-off-by: Vikas Saxena <[email protected]>

updated gpg signature for intel image

Signed-off-by: Vikas Saxena <[email protected]>

updating new intel oneAPI key

Signed-off-by: Vikas Saxena <[email protected]>

replacing curl by wget as the underling image doesnt have curl

Signed-off-by: Vikas Saxena <[email protected]>

# This is the commit message kubeflow#2:

Revert "replacing curl by wget as the underling image doesnt have curl"

This reverts commit bdc5798.

Signed-off-by: Vikas Saxena <[email protected]>

# This is the commit message kubeflow#3:

Revert "updating new intel oneAPI key"

This reverts commit 6cb0042.

Signed-off-by: Vikas Saxena <[email protected]>

# This is the commit message kubeflow#4:

updaung the key intel gpg key

Signed-off-by: Vikas Saxena <[email protected]>

# This is the commit message kubeflow#5:

adding fix for key

Signed-off-by: Vikas Saxena <[email protected]>
@vikas-saxena02
resolving merge cnflicts in intel.Dockerfile 6
922e947 
Signed-off-by: Vikas Saxena <[email protected]>
@vikas-saxena02
fixed based with kustomize edit fix
9dffb8a 
Signed-off-by: Vikas Saxena <[email protected]>

fixed overlays/kubeflow with kustomize edit fix

Signed-off-by: Vikas Saxena <[email protected]>

fixed overlays/standalone with kustomize edit fix

Signed-off-by: Vikas Saxena <[email protected]>

updated gpg signature for intel image

Signed-off-by: Vikas Saxena <[email protected]>

updating new intel oneAPI key

Signed-off-by: Vikas Saxena <[email protected]>

replacing curl by wget as the underling image doesnt have curl

Signed-off-by: Vikas Saxena <[email protected]>

Revert "replacing curl by wget as the underling image doesnt have curl"

This reverts commit bdc5798.

Signed-off-by: Vikas Saxena <[email protected]>

Revert "updating new intel oneAPI key"

This reverts commit 6cb0042.

Signed-off-by: Vikas Saxena <[email protected]>

updaung the key intel gpg key

Signed-off-by: Vikas Saxena <[email protected]>

adding fix for key

Signed-off-by: Vikas Saxena <[email protected]>

trying gog dearmour first

Signed-off-by: Vikas Saxena <[email protected]>

adding trusted-yes as found on stackoverflow.com

Signed-off-by: Vikas Saxena <[email protected]>

fixing curl releated issue in the docker fke

Signed-off-by: Vikas Saxena <[email protected]>

corrected typo

Signed-off-by: Vikas Saxena <[email protected]>

fixing self inflicted damages of updating wrong file

Signed-off-by: Vikas Saxena <[email protected]>
@vikas-saxena02 vikas-saxena02 force-pushed the fix_kustomize5_warnings branch from a727d45 to 9dffb8a Compare April 16, 2025 22:05
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rongou for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vikas-saxena02
resolving errors after rebase
49c46be 
Signed-off-by: Vikas Saxena <[email protected]>
@vikas-saxena02
removed duplicates
afad2b2 
Signed-off-by: Vikas Saxena <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carmark carmark Awaiting requested review from carmark

@gaocegege gaocegege Awaiting requested review from gaocegege

Assignees
No one assigned
Labels
do-not-merge/hold size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vikas-saxena02 @tenzen-y