[feature]: migrate docker image push to ghcr

[mahdikhashan]

fixes #684

cc: @thesuperzapper @tenzen-y

[thesuperzapper]

@mahdikhashan You will need to store this image under ghcr.io/kubeflow/mpi-operator/controller.

Note that IMAGE_NAME: mpioperator/mpi-operator so using that variable will not work.

[mahdikhashan]

done.

[tenzen-y]

@mahdikhashan I fixed CI errors in a separate place. Could you rebase this one?

[mahdikhashan]

@mahdikhashan I fixed CI errors in a separate place. Could you rebase this one?

sure, is it already merged to master? or would you share the branch?

[tenzen-y]

@mahdikhashan I fixed CI errors in a separate place. Could you rebase this one?

sure, is it already merged to master? or would you share the branch?

Fixes has already merged into the master branch.

[thesuperzapper]

Don't you also need to update your deployment manifests to use this new image?

The goal is that we use GHCR by default, as it does not have limits.

[tenzen-y]

Don't you also need to update your deployment manifests to use this new image?

The goal is that we use GHCR by default, as it does not have limits.

Yes, we need to replace it everywhere. Additionally, I think we need to address every images including MPI base images

mpi-operator/Makefile

Line 30 in 44941a1

REGISTRY?=docker.io/mpioperator

[mahdikhashan]

I'll update it.

[tenzen-y]

Furthermore, could you update docs as well?

mpi-operator/README.md

Line 243 in 44941a1

We push Docker images of [mpioperator on Dockerhub](https://hub.docker.com/u/mpioperator) for every release.

[google-oss-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tenzen-y for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mahdikhashan]

@tenzen-y i think we need to update the image usage in the separate pr. shall i open another one and merge it after we merge this one?

[tenzen-y]

@tenzen-y i think we need to update the image usage in the separate pr. shall i open another one and merge it after we merge this one?

Sure

[mahdikhashan]

@tenzen-y it seems to be ready, the other pr is #698 .

also, i'm not sure what i need to do with other images here: https://hub.docker.com/u/mpioperator, please let me know. thanks