Fix missing ReplicaIndexLabel when using RunLauncherAsWorker #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @tenzen-y |
Thank you for fixing this. At first glance, fixing looks reasonable. Let me review this more deeply, later. |
|
cc: @mimowo |
|
@GonzaloSaez could you sign CLA? |
|
LGTM |
GonzaloSaez
force-pushed
the
fix_missing_index_label_runlauncherasworker
branch
from
90a4857 to
686009e
Compare
tenzen-y
reviewed
Apr 14, 2025
There was a problem hiding this comment.
Everything looks great to me. Thank you!
@GonzaloSaez I fixed the CI errors in a separate PR.
So, could you rebase this PR?
After that we can merge this PR, thanks.
Signed-off-by: GonzaloSaez <[email protected]>
GonzaloSaez
force-pushed
the
fix_missing_index_label_runlauncherasworker
branch
from
686009e to
55ad4cb
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kueue's TAS expects all pods in a Pod Group to have the pod index label. Else it starts printing out annoying errors like
failed to read rank information from Pods. The latter happens when using RunLauncherAsWorker. To fix this we need to add the pod index label to the launchers' pod.