chore: Bump actions/setup-go from 5.6.0 to 6.4.0#1070
Open
dependabot[bot] wants to merge 1 commit into
Open
Conversation
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 5.6.0 to 6.4.0. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@40f1582...4a36011) --- updated-dependencies: - dependency-name: actions/setup-go dependency-version: 6.4.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
dependabot
Bot
added
the
github_actions
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: paulovmr The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
andyatmiami
suggested changes
May 9, 2026
Contributor
andyatmiami
left a comment
andyatmiami
left a comment
There was a problem hiding this comment.
Doesn't seem like this is going to work as is...
Run make build
make build
shell: /usr/bin/bash -e {0}
env:
GOTOOLCHAIN: local
Downloading sigs.k8s.io/controller-tools/cmd/controller-gen@v0.20.1
go: sigs.k8s.io/controller-tools/cmd/controller-gen@v0.20.1: sigs.k8s.io/controller-tools@v0.20.1 requires go >= 1.25.0 (running go 1.24.13; GOTOOLCHAIN=local)
make: *** [Makefile:188: /home/runner/work/kubeflow-notebooks/kubeflow-notebooks/workspaces/controller/bin/controller-gen] Error 1
Claude analysis:
The issue: the controller's Makefile runs go install sigs.k8s.io/controller-tools/cmd/controller-gen@v0.20.1 which internally requires go >= 1.25.0. With v5, Go would silently auto-download a go 1.25 toolchain. With v6's GOTOOLCHAIN=local, that auto-download is blocked and the build fails.
This means my verdict on PR #1070 should be revised:
Verdict: ❌ Workflow update required before merging
Options to fix:
1. Bump go.mod to go 1.25.x — aligns the project with what its tooling requires, but is a broader change
2. Override GOTOOLCHAIN in the workflow step — add env: GOTOOLCHAIN: auto to the make build step to restore the old behavior, but this defeats the purpose of the v6 safety improvement
3. Pin controller-gen to a version that works with go 1.24 — may not be feasible if v0.20.1 is needed
4. Stay on actions/setup-go@v5 until the project is ready to bump to go 1.25 — safest short-term option
Contributor
|
Very nice catch @andyatmiami, this went past me! 🤔 Thinking about it I have two comments:
So I guess we can't merge this right now before updating the go version, I'll unblock this after the update to a post 1.25 go version has happened ... /hold |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps actions/setup-go from 5.6.0 to 6.4.0.
Release notes
Sourced from actions/setup-go's releases.
... (truncated)
Commits
4a36011docs: fix Microsoft build of Go link (#734)8f19afcfeat: add go-download-base-url input for custom Go distributions (#721)27fdb26Bump minimatch from 3.1.2 to 3.1.5 (#727)def8c39Rearrange README.md, add advanced-usage.md (#724)4b73464Fix golang download url to go.dev (#469)a5f9b05Update default Go module caching to use go.mod (#705)7a3fe6cBump qs from 6.14.0 to 6.14.1 (#703)b9adafdBump actions/checkout from 5 to 6 (#686)d73f6bcREADME.md: correct to actions/checkout@v6 (#683)ae252eeBump@actions/cacheto v5 (#695)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)