fix: log rows.Close() errors instead of silently discarding them

[praneshnikhar]

Description

The migrateCleanupUniqueIndexes function in client_manager.go used _ = rows.Close() to suppress close errors from sql.Rows. This silently drops connection/IO errors that could indicate resource leaks or database issues.

Replaced _ = rows.Close() with a check that logs the error via glog.Warningf so close failures are visible in logs without altering control flow.

Change type

/kind bug

Changelog

fix: Log sql.Rows.Close() errors in client_manager.go instead of silently discarding them

[google-oss-prow]

@praneshnikhar: The label(s) kind/fix cannot be applied, because the repository doesn't have them.

Details

In response to this:

Description

The migrateCleanupUniqueIndexes function in client_manager.go used _ = rows.Close() to suppress close errors from sql.Rows. This silently drops connection/IO errors that could indicate resource leaks or database issues.

Replaced _ = rows.Close() with a check that logs the error via glog.Warningf so close failures are visible in logs without altering control flow.

Change type

/kind fix

Changelog

fix: Log sql.Rows.Close() errors in client_manager.go instead of silently discarding them

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[google-oss-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mprahl for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• backend/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[google-oss-prow]

Hi @praneshnikhar. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[hbelmiro]

/ok-to-test

[hbelmiro]

/retest