Skip to content

Conversation

@Reamer
Copy link
Contributor

@Reamer Reamer commented Sep 3, 2025

Purpose of this PR

This change performs string interpolation during the creation of the temporary file, which is used on Openshift.
There is a parallel pull request that also corrects this behaviour in the official Spark images. apache/spark-docker#90

Proposed changes:

  • correct entrypoint.sh for Openshift

Change Category

  • Bugfix (non-breaking change which fixes an issue)

Rationale

See issue #2644

Checklist

  • I have conducted a self-review of my own code.
  • I have updated documentation accordingly.
  • I have added tests that prove my changes are effective or that my feature works.
  • Existing unit tests pass locally with my changes.

Additional Notes

@google-oss-prow google-oss-prow bot requested review from ImpSy and nabuskey September 3, 2025 08:06
@Reamer Reamer force-pushed the entrypoint_openshift branch from 9e22e21 to 8aaa814 Compare September 3, 2025 08:06
@Reamer Reamer force-pushed the entrypoint_openshift branch from 8aaa814 to 63da0b5 Compare September 3, 2025 08:09
Copy link
Contributor

@nabuskey nabuskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM this fixes a bug where user entries were not generated correctly

Copy link
Member

@ChenYi015 ChenYi015 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@google-oss-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChenYi015

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit b621d81 into kubeflow:master Oct 21, 2025
18 checks passed
@ChenYi015 ChenYi015 linked an issue Oct 21, 2025 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression with NSS_WRAPPER_PASSWD

3 participants