Skip to content

Remove the logic for creating cloud-config for in-tree CCM #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove the logic for creating cloud-config for in-tree CCM #493

wants to merge 1 commit into from

Conversation

@buraksekili
Copy link

What this PR does / why we need it:

This PR removes any logic in OSPs and OSM regarding creating cloud-config for in-tree CCM and ensures that kubelet uses external cloud-provider.

reference: https://kubernetes.io/blog/2023/12/13/kubernetes-v1-29-release/#in-tree-cloud-provider-integration-removal

Which issue(s) this PR fixes:

Fixes #436

What type of PR is this?

/kind cleanup

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Remove support for in-tree CCM as it is deprecated in Kubernetes v1.29.
This implies that kubelet will use the external cloud-provider option by default.

Documentation:

TBD

@buraksekili
Remove the logic for creating cloud-config for in-tree CCM, as in-tree
a3fe872 
CCM is deprecated starting from v1.29.

> reference: https://kubernetes.io/blog/2023/12/13/kubernetes-v1-29-release/#in-tree-cloud-provider-integration-removal

This commit removes any logic in OSPs and OSM regarding creating
cloud-config for in-tree CCM and ensures that kubelet uses external
cloud-provider.

Signed-off-by: Burak Sekili <[email protected]>
@kubermatic-bot kubermatic-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. docs/tbd Denotes a PR that needs documentation (change) that will be done later. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. labels Jul 11, 2025
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign cnvergence for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 11, 2025
@buraksekili buraksekili self-assigned this Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@buraksekili buraksekili

Labels

dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/tbd Denotes a PR that needs documentation (change) that will be done later. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove cloud-config from OSPs and OSM

2 participants

@buraksekili @kubermatic-bot