Skip to content

openapi: add missing GroupVersionKind definition to apidiscovery_definitions.json#303

Open
Copilot wants to merge 1 commit into
masterfrom
copilot/fix-issue-in-repo-4834
Open

openapi: add missing GroupVersionKind definition to apidiscovery_definitions.json#303
Copilot wants to merge 1 commit into
masterfrom
copilot/fix-issue-in-repo-4834

Conversation

Copilot AI commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

apidiscovery_definitions.json references io.k8s.apimachinery.pkg.apis.meta.v1.GroupVersionKind in the V2 and v2beta1 discovery types (responseKind, acceptedTypes) but never defines the type itself. This causes openapi-generator to emit references to an unresolvable class, breaking Java client generation.

Changes

  • openapi/apidiscovery_definitions.json: Added the missing io.k8s.apimachinery.pkg.apis.meta.v1.GroupVersionKind schema definition with group, kind, and version string properties (all required).

This is the source fix for the workaround applied in kubernetes-client/java#4834, which injected the definition at generation time via a pre-processing script.

@kubernetes-prow kubernetes-prow Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 25, 2026
@kubernetes-prow kubernetes-prow Bot requested review from yliaog and yue9944882 June 25, 2026 18:20
@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Copilot
Once this PR has been reviewed and has the lgtm label, please ask for approval from brendandburns. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@linux-foundation-easycla

Copy link
Copy Markdown

CLA Not Signed

@brendandburns brendandburns marked this pull request as ready for review June 25, 2026 18:20
@kubernetes-prow kubernetes-prow Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants