Skip to content

clear service from status on sandbox expiry #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

clear service from status on sandbox expiry #102

wants to merge 1 commit into from
+5 −6

Conversation

@barney-s
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 18, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 18, 2025
@netlify
Copy link

netlify bot commented Oct 18, 2025 •
edited
Loading

✅ Deploy Preview for agent-sandbox canceled.

Name Link
🔨 Latest commit bcb32c8
🔍 Latest deploy log https://app.netlify.com/projects/agent-sandbox/deploys/68f6ce9b539e0b0008d5c23d

@barney-s
Copy link
Contributor Author

Test assertion needs to be fixed.

@barney-s barney-s force-pushed the clear_service branch 2 times, most recently from 00ca669 to 837fec6 Compare October 20, 2025 23:13
sdowell
sdowell approved these changes Oct 20, 2025
View reviewed changes
Copy link
Contributor

@sdowell sdowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 20, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: barney-s, sdowell
Once this PR has been reviewed and has the lgtm label, please assign janetkuo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sdowell
sdowell reviewed Oct 20, 2025
View reviewed changes
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 20, 2025
sdowell
sdowell reviewed Oct 20, 2025
View reviewed changes
Copy link
Contributor

@sdowell sdowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 20, 2025
janetkuo
janetkuo reviewed Oct 20, 2025
View reviewed changes
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 21, 2025
@barney-s barney-s requested review from janetkuo and sdowell October 21, 2025 00:13
sdowell
sdowell reviewed Oct 21, 2025
View reviewed changes
Copy link
Contributor

@sdowell sdowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinsb justinsb Awaiting requested review from justinsb

@janetkuo janetkuo Awaiting requested review from janetkuo

1 more reviewer

@sdowell sdowell sdowell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sdowell sdowell

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@barney-s @k8s-ci-robot @sdowell @janetkuo