-
Notifications
You must be signed in to change notification settings - Fork 31
[docs]: Add GKE deployment guide #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for agent-sandbox canceled.
|
|
Welcome @syangx39! |
|
Hi @syangx39. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| @@ -0,0 +1,165 @@ | |||
| # GKE Deployment Guide | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest merging this with the README here
https://github.com/kubernetes-sigs/agent-sandbox/tree/main/examples/python-runtime-sandbox#testing-on-a-local-kind-cluster-using-agent-sandbox
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a GKE example. Should we keep this under GKE ?
I think we'll eventually move this to GKE docs but this is a good start to add here.
|
/approve |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: aditya-shantanu, syangx39 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR adds a step-by-step guide (gke-deployment-guide.md) for deploying the agent-sandbox controller and the Python runtime example on Google Kubernetes Engine (GKE).