Add support for shutdownTime in sandbox.spec #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
This was referenced Sep 25, 2025
|
@flpanbin FYI |
janetkuo
reviewed
Sep 25, 2025
janetkuo
reviewed
Sep 25, 2025
barney-s
force-pushed
the
sandbox-expiry
branch
from
cd6e3a3 to
0731570
Compare
k8s-ci-robot
added
the
needs-rebase
barney-s
force-pushed
the
sandbox-expiry
branch
from
0731570 to
05359f5
Compare
k8s-ci-robot
removed
the
needs-rebase
vicentefb
reviewed
Sep 26, 2025
janetkuo
reviewed
Sep 26, 2025
janetkuo
reviewed
Sep 26, 2025
lengrongfu
reviewed
Sep 27, 2025
lengrongfu
reviewed
Sep 27, 2025
barney-s
force-pushed
the
sandbox-expiry
branch
2 times, most recently
from
c8abdd8 to
12e852a
Compare
flpanbin
reviewed
Sep 29, 2025
barney-s
force-pushed
the
sandbox-expiry
branch
from
12e852a to
677b171
Compare
barney-s
changed the title
barney-s
force-pushed
the
sandbox-expiry
branch
from
677b171 to
7c2cc57
Compare
lengrongfu
reviewed
Sep 30, 2025
barney-s
force-pushed
the
sandbox-expiry
branch
from
7c2cc57 to
1edfade
Compare
justinsb
reviewed
Oct 1, 2025
barney-s
force-pushed
the
sandbox-expiry
branch
from
1edfade to
797fdaa
Compare
barney-s
force-pushed
the
sandbox-expiry
branch
2 times, most recently
from
182346c to
3b1d78b
Compare
justinsb
reviewed
Oct 1, 2025
justinsb
approved these changes
Oct 1, 2025
k8s-ci-robot
added
the
approved
barney-s
force-pushed
the
sandbox-expiry
branch
from
3b1d78b to
e9d6040
Compare
* Add .spec.shutdownTime string that parses to a time * The child resources are deleted once the current time >= shutdownAt time * Sandbox is not deleted
barney-s
force-pushed
the
sandbox-expiry
branch
from
e9d6040 to
a914d61
Compare
justinsb
approved these changes
Oct 2, 2025
| // Update status to remove Ready condition | ||
| meta.SetStatusCondition(&sandbox.Status.Conditions, metav1.Condition{ | ||
| Type: string(sandboxv1alpha1.SandboxConditionReady), | ||
| Status: metav1.ConditionFalse, |
There was a problem hiding this comment.
Not sure this is not ready... The object has been reconciled and is not expected to change state. But let's see what feels natural in use
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: barney-s, justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pared down version of #21
implements #18 partially