-
Notifications
You must be signed in to change notification settings - Fork 815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add make file target for testing images #2385
base: master
Are you sure you want to change the base?
Conversation
Code Coverage DiffThis PR does not change the code coverage |
d57ee77
to
6c02e4a
Compare
6c02e4a
to
76d0b77
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Largely lgtm - discussed offline and we agreed it would be best to let the janitor handle cleanup (which might require submitting a PR to kubernetes-sigs/boskos/aws-janitor
, separately). This is also more consistent with the existing build-image.sh
.
76d0b77
to
b1c55a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left two optional comments, otherwise lgtm (assuming CI job will work once we turn it on in test-infra).
Thanks for hopefully catching a few future makefile + hack script regressions a bit earlier!
b1c55a0
to
c0cbb50
Compare
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What is this PR about? / Why do we need it?
This PR adds a make file target which builds and pushes images to our
ECR
and then ensures that all images are pushed successfully. This will be used for a CI job after this is approvedHow was this change tested?
Manually running the make file target
Does this PR introduce a user-facing change?