Skip to content

Add Status.Conditions to AWSManagedCluster and ROSACluster #5393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
theobarberbany opened this issue Mar 14, 2025 · 2 comments · Fixed by #5394
Closed

Add Status.Conditions to AWSManagedCluster and ROSACluster #5393

theobarberbany opened this issue Mar 14, 2025 · 2 comments · Fixed by #5394
Assignees
@theobarberbany
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-priority triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone
v2.8

Comments

@theobarberbany
Copy link
Contributor

/kind feature

As the CAPI InfraCluster provider contract has been updated (see kubernetes-sigs/cluster-api#10519), we need to update the CAPA InfraCluster implementations. This involves adding a Paused condition.

Currently, both AWSManagedCluster and ROSACluster do not have a Conditions field in their Status, so no conditions can be set.

Describe the solution you'd like
[A clear and concise description of what you want to happen.]

both AWSManagedCluster and ROSACluster have a Conditions field in their Status.
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 14, 2025
@theobarberbany theobarberbany mentioned this issue Mar 14, 2025
Merged
5 tasks
@theobarberbany
Copy link
Contributor Author

cc @nrb @damdo

@nrb
Copy link
Contributor

nrb commented Mar 17, 2025

/triage accepted
/assign @theobarberbany
/milestone v2.8

@k8s-ci-robot k8s-ci-robot added this to the v2.8 milestone Mar 17, 2025
@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 17, 2025
@theobarberbany theobarberbany mentioned this issue Mar 25, 2025
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@theobarberbany theobarberbany

Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-priority triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v2.8
3 participants
@nrb @theobarberbany @k8s-ci-robot