Skip to content

✨ Updates AWSManagedCluster, ROSACluster with Paused Condition #5394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2025
Merged

✨ Updates AWSManagedCluster, ROSACluster with Paused Condition #5394

merged 1 commit into from
Mar 18, 2025

Conversation

theobarberbany
Copy link
Contributor

@theobarberbany theobarberbany commented Mar 14, 2025 •
edited by nrb
Loading

This change:

  • Updates the API for AWSManagedCluster to include a conditions field.
  • Sets Paused in the conditions if the controller is paused.

What type of PR is this?

/kind feature

/kind api-change

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #5393

Special notes for your reviewer:

Addresses

Checklist:

  • squashed commits
  • includes documentation
  • includes emoji in title
  • adds unit tests
  • adds or updates e2e tests

Release note:

Adds optional `Conditions` field to `Status` for AWSManagedCluster, ROSACluster. Sets `Paused` condition when reconciliation is paused (Contract change)

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 14, 2025
@k8s-ci-robot k8s-ci-robot added needs-priority size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 14, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @theobarberbany. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@theobarberbany theobarberbany mentioned this pull request Mar 17, 2025
Merged
5 tasks
@theobarberbany theobarberbany force-pushed the awsmanagedcluster-paused branch from f14bb22 to 13908b8 Compare March 17, 2025 15:06
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 17, 2025
@theobarberbany theobarberbany changed the title Updates AWSManagedCluster with Paused Condition Updates AWSManagedCluster, ROSACluster with Paused Condition Mar 17, 2025
@theobarberbany theobarberbany marked this pull request as ready for review March 17, 2025 15:06
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 17, 2025
@k8s-ci-robot k8s-ci-robot requested review from nrb and serngawy March 17, 2025 15:06
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 17, 2025
@theobarberbany theobarberbany force-pushed the awsmanagedcluster-paused branch from 13908b8 to 7d2c7b6 Compare March 17, 2025 16:54
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 17, 2025
@theobarberbany theobarberbany force-pushed the awsmanagedcluster-paused branch from 7d2c7b6 to f4721a8 Compare March 17, 2025 17:13
@damdo
Copy link
Member

damdo commented Mar 17, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 17, 2025
@nrb
Copy link
Contributor

nrb commented Mar 17, 2025

Looks good to me, but you'll need to run make generate like the verification job error says.

@theobarberbany
AWSManagedCluster, ROSACluster add Paused Condition
b9aa06b 
Updates AWSManagedCluster with Paused Condition

This change:

 - Updates the API for AWSManagedCluster to include a conditions field.
 - Sets `Paused` in the conditions if the controller is paused.

Updates ROSACluster with Paused Condition

This change:
  - Updates the API for ROSACluster to include a conditions field.
  - Sets `Paused` in the conditions if the controller is paused.

Updates generated API types
@theobarberbany theobarberbany force-pushed the awsmanagedcluster-paused branch from f4721a8 to b9aa06b Compare March 18, 2025 08:22
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 18, 2025
@theobarberbany theobarberbany changed the title Updates AWSManagedCluster, ROSACluster with Paused Condition ✨ Updates AWSManagedCluster, ROSACluster with Paused Condition Mar 18, 2025
@theobarberbany
Copy link
Contributor Author

make generate run, and commits squashed :)

damdo
damdo reviewed Mar 18, 2025
View reviewed changes
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @theobarberbany

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2025
@damdo
Copy link
Member

damdo commented Mar 18, 2025

/assign @nrb @richardcase

serngawy
serngawy approved these changes Mar 18, 2025
View reviewed changes
Copy link
Contributor

@serngawy serngawy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks @theobarberbany

@nrb
Copy link
Contributor

nrb commented Mar 18, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nrb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2025
@k8s-ci-robot k8s-ci-robot merged commit a11fb5c into kubernetes-sigs:main Mar 18, 2025
28 of 30 checks passed
@theobarberbany theobarberbany deleted the awsmanagedcluster-paused branch March 18, 2025 17:23
nrb added a commit to nrb/cluster-api-provider-aws that referenced this pull request Mar 19, 2025
@nrb
Allow controllers to patch clusters/status
ef5cca8 
While kubernetes-sigs#5394 and kubernetes-sigs#5383 added support for patching a cluster/status in the
cluster.x-k8s.io API group, neither added the patch permission for the
associated controllers.

This commit adds RBAC support for patching cluster/status

Signed-off-by: Nolan Brubaker <[email protected]>
@nrb nrb mentioned this pull request Mar 19, 2025
Merged
2 tasks
@theobarberbany theobarberbany mentioned this pull request Mar 25, 2025
Closed
11 tasks
punkwalker pushed a commit to punkwalker/cluster-api-provider-aws that referenced this pull request May 1, 2025
@nrb @punkwalker
Allow controllers to patch clusters/status
36c00ec 
While kubernetes-sigs#5394 and kubernetes-sigs#5383 added support for patching a cluster/status in the
cluster.x-k8s.io API group, neither added the patch permission for the
associated controllers.

This commit adds RBAC support for patching cluster/status

Signed-off-by: Nolan Brubaker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damdo damdo damdo left review comments

@serngawy serngawy serngawy approved these changes

@fiunchinho fiunchinho Awaiting requested review from fiunchinho

@luthermonson luthermonson Awaiting requested review from luthermonson

@nrb nrb Awaiting requested review from nrb

Assignees

@richardcase richardcase

@nrb nrb

@damdo damdo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Status.Conditions to AWSManagedCluster and ROSACluster
6 participants
@theobarberbany @k8s-ci-robot @damdo @nrb @serngawy @richardcase