Skip to content

🌱 feat: add kal linter #5392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

🌱 feat: add kal linter #5392

wants to merge 4 commits into from

Conversation

richardcase
Copy link
Member

@richardcase richardcase commented Mar 13, 2025 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

This adds the setup / makefile changes required to add the Kubernetes API Linter.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #5494
Fixes #5493

Special notes for your reviewer:

The additional KAL linter will be enabled in separate PR so as to reduce the number of changes for review.

Checklist:

  • squashed commits
  • includes documentation
  • includes emoji in title
  • adds unit tests
  • adds or updates e2e tests

Release note:

Add Kubernetes API Linter to project.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 13, 2025
@k8s-ci-robot k8s-ci-robot requested review from AndiDog and damdo March 13, 2025 08:38
@k8s-ci-robot k8s-ci-robot added needs-priority size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 13, 2025
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 14, 2025
@richardcase richardcase changed the title WIP: add kal linter 🌱 WIP: add kal linter May 14, 2025
@richardcase
wip: add kal linter
a0522bd 
Signed-off-by: Richard Case <[email protected]>
@richardcase
wip: add kal linter
6a9c13e 
Signed-off-by: Richard Case <[email protected]>
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign vincepri for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 14, 2025
@richardcase
wip: add kal linter
fad1e81 
Signed-off-by: Richard Case <[email protected]>
@richardcase
wip: add kal linter
36c7812 
Signed-off-by: Richard Case <[email protected]>
@richardcase richardcase marked this pull request as ready for review May 14, 2025 17:03
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 14, 2025
@k8s-ci-robot k8s-ci-robot requested a review from faiq May 14, 2025 17:03
@richardcase richardcase changed the title 🌱 WIP: add kal linter 🌱 feat: add kal linter May 14, 2025
alexander-demicev
alexander-demicev approved these changes May 16, 2025
View reviewed changes
Copy link
Contributor

@alexander-demicev alexander-demicev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome work! 🚀
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cbd122a238d3e6a63edef251c3b12dbff41b7850

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-demicev alexander-demicev alexander-demicev approved these changes

@AndiDog AndiDog Awaiting requested review from AndiDog

@damdo damdo Awaiting requested review from damdo

@faiq faiq Awaiting requested review from faiq

Assignees

@alexander-demicev alexander-demicev

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[KAL] Add linter and initial make targets [KAL] Enable the statussubresource linter
3 participants
@richardcase @k8s-ci-robot @alexander-demicev