Skip to content

🐛 Skip adding reserved aws internal tags to resources as they are invalid #5461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

athiruma
Copy link
Contributor

@athiruma athiruma commented Apr 9, 2025

What type of PR is this?

What this PR does / why we need it:
Skip adding reserved aws internal tags (that start with aws:) to resources as they are invalid and will cause instance creation errors:

I0409 03:42:59.545979       1 awsmachine_controller.go:732] "Creating EC2 instance"
E0409 03:43:01.676476       1 awsmachine_controller.go:535] "unable to create instance" err=<
failed to create AWSMachine instance: failed to create tags for resource "eni-05807e398e7f79df3": : failed to create tags for resource "eni-05807e398e7f79df3": map[MachineName:openshift-cluster-api/capimachineset-ct2tn Name:capimachineset-ct2tn aws:ec2:capacity-reservation-type:capacity-block kubernetes.io/cluster/huliu-aws49a-bwrxg:owned sigs.k8s.io/cluster-api-provider-aws/cluster/huliu-aws49a-bwrxg:owned sigs.k8s.io/cluster-api-provider-aws/role:node]: InvalidParameterValue: Value ( aws:ec2:capacity-reservation-type ) for parameter key is invalid. Tag keys starting with 'aws:' are reserved for internal use
status code: 400, request id: fe84aa27-7975-48c0-946a-e10ab25d7c16

External BUG reference:
OCPBUGS-54757

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • includes emoji in title
  • adds unit tests
  • adds or updates e2e tests

Release note:

Skip adding reserved aws internal tags to resources as they are invalid

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 9, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign richardcase for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from nrb and richardcase April 9, 2025 10:25
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 9, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @athiruma. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 9, 2025
@athiruma athiruma changed the title Skip the aws internal tags 🐛 Skip the aws internal tags Apr 9, 2025
@richardcase
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 9, 2025
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that it LGTM

thanks @athiruma

@damdo damdo changed the title 🐛 Skip the aws internal tags 🐛 Skip adding reserved aws internal tags to resources as they are invalid Apr 10, 2025
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 10, 2025
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/assign @nrb @richardcase @AndiDog

for approval

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 10, 2025
@athiruma
Copy link
Contributor Author

@AndiDog ptal! 👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants