🐛 Launchtemplate needs to be updated if spot options are changed

[fiunchinho]

What type of PR is this?

/kind bug

What this PR does / why we need it:

When the spot instances options are changed, we want to update the launch template so that the changes take effect.

Special notes for your reviewer:

I've changed the unit tests for the LaunchTemplateNeedsUpdate function, because some cases were passing by pure chance. Basically these security groups are always added to the incoming AWSLaunchTemplate

{ID: aws.String("sg-111")},
{ID: aws.String("sg-222")},

So if the existing AWSLaunchTemplate that we use in the tests don't have these security groups, the function will always return true. Tests like the one testing changes to the IamInstanceProfile field were passing because of the different security groups, rather than the change on the IamInstanceProfile field.

Checklist:

• squashed commits
• includes documentation
• includes emoji in title
• adds unit tests
• adds or updates e2e tests

Release note:

LaunchTemplate needs to be updated if spot options are changed

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign dlipovetsky for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[fiunchinho]

/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-eks

[alexander-demicev]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: d778b6d36ce012772b2bb23779e7a386fca21354

[k8s-ci-robot]

New changes are detected. LGTM label has been removed.

[fiunchinho]

/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-eks

[fiunchinho]

@alexander-demicev After testing the changes in our management cluster, I needed to do more changes to make this work. PTAL, thanks.